Messages in this thread | | | Date | Fri, 20 Jun 2014 13:40:27 -0700 | From | Greg Kroah-Hartman <> | Subject | Re: [PATCH] trivial: drivers/staging/rtl8821ae/rtl8821ae: Fix closing brace followed by if |
| |
On Fri, Jun 20, 2014 at 10:21:45PM +0200, Rasmus Villemoes wrote: > Greg Kroah-Hartman <gregkh@linuxfoundation.org> writes: > > > On Fri, Jun 20, 2014 at 09:56:35PM +0200, Rasmus Villemoes wrote: > >> All of the code is #if 0'd out, and the change just replaces a > >> space with a newline, so this obviously doesn't change anything. > > > > How about just deleting all the #if 0 code out entirely so no one has to > > worry about it anymore? > > Fine by me. Like this? > > From: Rasmus Villemoes <linux@rasmusvillemoes.dk> > Subject: [PATCH] drivers/staging/rtl8821ae/rtl8821ae: Remove dead code > > This is all #if 0'ed out, and it contains some rather weird stuff > (post-increment of a bool, for example). Nuke it. > > Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
Looks good, if you send it in a stand-along email, I can even apply it :)
thanks,
greg k-h
| |