Messages in this thread | | | Date | Fri, 20 Jun 2014 13:49:36 +0530 | Subject | Re: [patch 08/13] irqchip: spear_shirq: Precalculate status mask | From | Viresh Kumar <> |
| |
On 20 June 2014 13:36, Thomas Gleixner <tglx@linutronix.de> wrote: > On Fri, 20 Jun 2014, Viresh Kumar wrote: >> On Fri, Jun 20, 2014 at 3:04 AM, Thomas Gleixner <tglx@linutronix.de> wrote: >> > @@ -176,6 +186,7 @@ static struct spear_shirq spear320_shirq >> > static struct spear_shirq spear320_shirq_intrcomm_ras = { >> > .offset = 11, >> > .nr_irqs = 11, >> > + .mask = ((0x1 << 11) - 1) << 11, >> > .regs = { >> > .enb_reg = -1, >> > .status_reg = SPEAR320_INT_STS_MASK_REG, >> >> If you like, maybe this instead of above diff: > > What's wrong with letting the compiler fill it in?
>> + shirq_blocks[i]->mask = ((0x1 << shirq_blocks[i]->nr_irqs) - 1) >> + << shirq_blocks[i]->offset;
Just for better readability as it doesn't have magic numbers in it and the performance impact wouldn't be much as its done just once on boot.
| |