lkml.org 
[lkml]   [2014]   [Jun]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH] staging: rtl8192 Check for Null return from dev_skb_alloc
    From
    If anyone able to check this patch it would be great.
    Thanks Nick

    On Thu, Jun 19, 2014 at 5:18 PM, Nicholas Krause <xerofoify@gmail.com> wrote:
    > Checks for Null return from dev_skb_alloc if it returns Null,
    > fw_download returns false. Otherwise it returns true.Also
    > removed rt_status due to returning true of false directly.
    >
    > Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
    > ---
    > drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c | 7 ++++---
    > 1 file changed, 4 insertions(+), 3 deletions(-)
    >
    > diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c b/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c
    > index 1a95d1f..affa89a 100644
    > --- a/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c
    > +++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c
    > @@ -36,7 +36,6 @@ static bool fw_download_code(struct net_device *dev, u8 *code_virtual_address,
    > u32 buffer_len)
    > {
    > struct r8192_priv *priv = rtllib_priv(dev);
    > - bool rt_status = true;
    > u16 frag_threshold;
    > u16 frag_length, frag_offset = 0;
    > int i;
    > @@ -59,7 +58,9 @@ static bool fw_download_code(struct net_device *dev, u8 *code_virtual_address,
    > bLastIniPkt = 1;
    >
    > }
    > skb = dev_alloc_skb(frag_length + 4);
    > + if (!skb)
    > + return false;
    > memcpy((unsigned char *)(skb->cb), &dev, sizeof(dev));
    > tcb_desc = (struct cb_desc *)(skb->cb + MAX_DEV_ADDR_SIZE);
    > @@ -99,7 +100,7 @@ static bool fw_download_code(struct net_device *dev, u8 *code_virtual_address,
    >
    > write_nic_byte(dev, TPPoll, TPPoll_CQ);
    >
    > - return rt_status;
    > + return true;
    > }
    >
    > static bool CPUcheck_maincodeok_turnonCPU(struct net_device *dev)
    > --
    > 1.9.1
    >


    \
     
     \ /
      Last update: 2014-06-20 04:41    [W:2.375 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site