Messages in this thread | | | Date | Tue, 17 Jun 2014 21:54:03 -0700 | Subject | Re: [PATCH 10/10] mfd: cros_ec: ec_dev->cmd_xfer() returns number of bytes received from EC | From | Doug Anderson <> |
| |
Simon,
On Tue, Jun 17, 2014 at 8:46 PM, Simon Glass <sjg@chromium.org> wrote: > Hi, > > On 16 June 2014 14:40, Doug Anderson <dianders@chromium.org> wrote: >> From: Bill Richardson <wfrichar@chromium.org> >> >> When communicating with the EC, the cmd_xfer() function should return the >> number of bytes it received from the EC, or negative on error. > > This is just for the I2C tunnel feature, right? If so, I think this > should be mentioned here. It seems to be affecting ec_i2c_xfer(), not > cmd_xfer().
No, the tunnel feature is implemented just fine without this (and is already landed and working). It looks like the (not yet upstreamed) ec_i2c_limited_xfer for spring returns this new value directly but I'm not convinced that's technicall correct.
Bill can correct me if I'm wrong, but I think this is primarily interesting once we add in cros_ec_dev (the userspace API) which needs this info. Until that happens this patch doesn't hurt and just returns some extra info.
-Doug
| |