[lkml]   [2014]   [Jun]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRE: [PATCH tty-next 14/22] tty: Remove tty_wait_until_sent_from_close()
From: Peter Hurley
> > I don't understand the second half of the changelog, it doesn't seem
> > to fit here: there deadlock that we are trying to avoid here happens
> > when the *same* tty needs the lock to complete the function that
> > sends the pending data. I don't think we do still do that any more,
> > but it doesn't seem related to the tty lock being system-wide or not.
> The tty lock is not used in the i/o path; it's purpose is to
> mutually exclude state changes in open(), close() and hangup().
> The commit that added this [1] comments that _other_ ttys may wait
> for this tty to complete, and comments in the code note that this
> function should be removed when the system-wide tty mutex was removed
> (which happened with the commit noted in the changelog).

What happens if another process tries to do a non-blocking open
while you are sleeping in close waiting for output to drain?

Hopefully this returns before that data has drained.


 \ /
  Last update: 2014-06-17 13:41    [W:0.069 / U:0.160 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site