Messages in this thread | | | Date | Mon, 16 Jun 2014 17:44:18 -0700 | From | Anish Bhatt <> | Subject | Re: [PATCH] checkpatch: Warn on unnecessary void function return statements |
| |
My code has multiple exit lables: void function(void) { ...
if (err1) goto exit1; ... if (err2) goto exit2;
... return; /* Good return, no errors */ exit1: printk(err1); return; exit2: printk(err2); }
The single tabbed return was required to prevent the good return & err1 messages cascading down. The extra exit label with a noop looks weird, but is passing checkpatch.pl --strict, so I will go with that, thanks. -Anish
| |