lkml.org 
[lkml]   [2014]   [Jun]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] checkpatch: Warn on unnecessary void function return statements
My code has multiple exit lables:
void function(void)
{
...

if (err1)
goto exit1;
...
if (err2)
goto exit2;

...
return; /* Good return, no errors */
exit1:
printk(err1);
return;
exit2:
printk(err2);
}

The single tabbed return was required to prevent the good return & err1
messages cascading down. The extra exit label with a noop looks weird,
but is passing checkpatch.pl --strict, so I will go with that, thanks.
-Anish



\
 
 \ /
  Last update: 2014-06-17 03:01    [W:2.008 / U:0.228 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site