lkml.org 
[lkml]   [2014]   [Jun]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] gpio-pxa: gpio0 and gpio1 support on dt
From
On Thu, Jun 12, 2014 at 4:43 PM, Linus Walleij <linus.walleij@linaro.org> wrote:
> On Thu, Jun 5, 2014 at 9:13 PM, Andrew Ruder
> <andrew.ruder@elecsyscorp.com> wrote:
>
>> pxa_gpio_probe() has some issues supporting the gpio0 and gpio1
>> interrupts under device-tree - it never actually sets up the chain
>> handler to get interrupts on edge detect for GPIO0 and GPIO1.
>>
>> Signed-off-by: Andrew Ruder <andrew.ruder@elecsyscorp.com>
>
> Makes perfect sense. Can I have an ACK from some PXA
> maintainer on this?
>
> The PXA GPIO driver with it's messy irqchip registration looks
> like a good candidate for switching to the gpiolib irqchip helpers
> and rid some code. Just saying.
>
> Yours,
> Linus Walleij

Acked-by: Haojian Zhuang <haojian.zhuang@gmail.com>

Yes, it's worth to rid some irqchip code.

Regards
Haojian


\
 
 \ /
  Last update: 2014-06-17 02:41    [W:0.311 / U:0.096 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site