Messages in this thread | ![/](/images/icornerl.gif) | | Date | Mon, 16 Jun 2014 20:59:19 +0200 | From | Fabian Frederick <> | Subject | Re: [PATCH V2] fs/omfs/inode.c: use ULLONG_MAX instead of ~0ULL |
| |
On Sun, 15 Jun 2014 12:11:42 -0400 Bob Copeland <me@bobcopeland.com> wrote:
> On Sun, Jun 15, 2014 at 08:39:20AM +0200, Fabian Frederick wrote: > > Use more explicit kernel.h definition > > array_size = DIV_ROUND_UP(bitmap_size, sb->s_blocksize); > > > > - if (sbi->s_bitmap_ino == ~0ULL) > > + if (sbi->s_bitmap_ino == ULLONG_MAX) > > goto out; > > So I agree they are the same, but is there a good reason for the > change? > > Semantically, I think of ~0ULL as "all ones" whereas ULLONG_MAX > as a maximum of a magnitude comparison, which this is not really.
Well it was meant to clarify code but in this case it doesn't indeed :)
Thanks, Fabian
> > -- > Bob Copeland %% www.bobcopeland.com
| ![\](/images/icornerr.gif) |