lkml.org 
[lkml]   [2014]   [Jun]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH V2] fs/omfs/inode.c: use ULLONG_MAX instead of ~0ULL
On Sun, 15 Jun 2014 12:11:42 -0400
Bob Copeland <me@bobcopeland.com> wrote:

> On Sun, Jun 15, 2014 at 08:39:20AM +0200, Fabian Frederick wrote:
> > Use more explicit kernel.h definition
> > array_size = DIV_ROUND_UP(bitmap_size, sb->s_blocksize);
> >
> > - if (sbi->s_bitmap_ino == ~0ULL)
> > + if (sbi->s_bitmap_ino == ULLONG_MAX)
> > goto out;
>
> So I agree they are the same, but is there a good reason for the
> change?
>
> Semantically, I think of ~0ULL as "all ones" whereas ULLONG_MAX
> as a maximum of a magnitude comparison, which this is not really.

Well it was meant to clarify code but in this case it doesn't indeed :)

Thanks,
Fabian

>
> --
> Bob Copeland %% www.bobcopeland.com


\
 
 \ /
  Last update: 2014-06-16 21:21    [W:0.046 / U:1.076 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site