Messages in this thread | | | Date | Sun, 15 Jun 2014 13:16:17 +0800 | Subject | Re: [RFC PATCH] gpio: Add a defer reset object to send board specific reset | From | Houcheng Lin <> |
| |
Hi Linus, please see my replies below,
2014-06-12 20:35 GMT+08:00 Linus Walleij <linus.walleij@linaro.org>: > > OK this is interesting stuff.. > > But this driver *MUST* live under drivers/power/reset/*, as it > has absolutely *nothing* to do with GPIO except for being a consumer > of it. I won't merge it. > > And you should discuss it with Dmitry and David W. > > But I will review it nevertheless :-D
Thanks for this information, I changed source to under drivers/ power/reset.
> > OK so reset init and reset end is a way to specify when reset > is asserted (as one or zero). > > DON'T do this. The GPIO bindings already know a way to define > if GPIOs are active high or low, and the gpiod interface will invert > the signal for you if this is specified as active low. > > This way you get rid of both strange properties. >
May I reserve the "reset-init" and ""reset-end" properties? As some boards use power line off to reset device. The power line is active high when as power but active low when as a reset signal.
> > You forgot to free the deferred_reset_list here. Fix that. >
Thank a lot for your reviews :) Here are fixed of version 2: - change location to drivers/power/reset - remove unused #include - change to use GPIO descriptor interface and use customer.h - free resources after issue reset. However, if a enclosing chip is not probled, the correpsonding reset will not send and memeory is still not free in this case. - other minor fixs
Best regards, Houcheng Lin
| |