lkml.org 
[lkml]   [2014]   [Jun]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
SubjectRe: [PATCH] Missing return check against Null for return value of netdev_alloc_dev_skb()
From
I am resending this patch as the email for Ben is wrong in the
maintainer script due to getting automated message from solarflare.
Signed-off-by: Nick <xerofoify@gmail.com>
---
drivers/net/ethernet/oki-semi/
pch_gbe/pch_gbe_main.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c
b/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c
index 73e6683..704cf63 100644
--- a/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c
+++ b/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c
@@ -1515,6 +1515,8 @@ static void pch_gbe_alloc_tx_buffers(struct
pch_gbe_adapter *adapter,
for (i = 0; i < tx_ring->count; i++) {
buffer_info = &tx_ring->buffer_info[i];
skb = netdev_alloc_skb(adapter->netdev, bufsz);
+ if (!skb)
+ return NULL;
skb_reserve(skb, PCH_GBE_DMA_ALIGN);
buffer_info->skb = skb;
tx_desc = PCH_GBE_TX_DESC(*tx_ring, i);
Thanks Nick
On Sun, Jun 15, 2014 at 12:05 AM, Nick <xerofoify@gmail.com> wrote:
> Signed-off-by: Nick <xerofoify@gmail.com>
> ---
> drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c b/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c
> index 73e6683..704cf63 100644
> --- a/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c
> +++ b/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c
> @@ -1515,6 +1515,8 @@ static void pch_gbe_alloc_tx_buffers(struct pch_gbe_adapter *adapter,
> for (i = 0; i < tx_ring->count; i++) {
> buffer_info = &tx_ring->buffer_info[i];
> skb = netdev_alloc_skb(adapter->netdev, bufsz);
> + if (!skb)
> + return NULL;
> skb_reserve(skb, PCH_GBE_DMA_ALIGN);
> buffer_info->skb = skb;
> tx_desc = PCH_GBE_TX_DESC(*tx_ring, i);
> --
> 1.9.1
>


\
 
 \ /
  Last update: 2014-06-15 07:21    [W:0.052 / U:23.540 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site