lkml.org 
[lkml]   [2014]   [Jun]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 0/2] make kASLR vs hibernation boot-time selectable
Date
On Saturday, June 14, 2014 09:41:19 AM H. Peter Anvin wrote:
> On 06/13/2014 05:39 PM, Rafael J. Wysocki wrote:
> >
> > -#define RESTORE_MAGIC 0x0123456789ABCDEFUL
> > +#define RESTORE_MAGIC 0x0123456789ABCDF0UL
> >
>
> <bikeshed>
>
> Please don't pick numbers like this for magic numbers... *everyone else
> does, too.* In general, picking a random number is a good starting
> point; for extra bonus make sure it has at least one invalid UTF-8
> sequence in it (so it cannot be confused with either ASCII or UTF-8 text.)
>
> </bikeshed>

OK, when we find out how to make hibernation work with the address space
randomization.

Rafael



\
 
 \ /
  Last update: 2014-06-16 01:01    [W:0.051 / U:0.640 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site