Messages in this thread | | | Date | Sun, 15 Jun 2014 19:58:49 +0200 | From | Jiri Olsa <> | Subject | Re: [PATCH 15/17] perf tools: Add debug prints for ordered events queue |
| |
On Fri, Jun 13, 2014 at 09:12:23PM +0900, Namhyung Kim wrote: > 2014-06-13 (금), 00:08 +0200, Jiri Olsa: > > Adding some prints for ordered events queue, to help > > debug issues. > > > > Cc: Arnaldo Carvalho de Melo <acme@kernel.org> > > Cc: Corey Ashford <cjashfor@linux.vnet.ibm.com> > > Cc: David Ahern <dsahern@gmail.com> > > Cc: Frederic Weisbecker <fweisbec@gmail.com> > > Cc: Ingo Molnar <mingo@kernel.org> > > Cc: Jean Pihet <jean.pihet@linaro.org> > > Cc: Namhyung Kim <namhyung@kernel.org> > > Cc: Paul Mackerras <paulus@samba.org> > > Cc: Peter Zijlstra <a.p.zijlstra@chello.nl> > > Signed-off-by: Jiri Olsa <jolsa@kernel.org> > > --- > > tools/perf/builtin-report.c | 4 +++ > > tools/perf/util/ordered-events.c | 54 ++++++++++++++++++++++++++++++++++++++++ > > tools/perf/util/ordered-events.h | 2 ++ > > 3 files changed, 60 insertions(+) > > > > diff --git a/tools/perf/builtin-report.c b/tools/perf/builtin-report.c > > index 09b9d0c..130ab5c 100644 > > --- a/tools/perf/builtin-report.c > > +++ b/tools/perf/builtin-report.c > > @@ -82,6 +82,10 @@ static int report__config(const char *var, const char *value, void *cb) > > rep->queue_size = perf_config_u64(var, value); > > return 0; > > } > > + if (!strcmp(var, "report.queue-debug")) { > > + debug_sample_queue = perf_config_int(var, value); > > + return 0; > > + } > > Again, config option only?
same reason as for the previous one
> > + > > +#define pr_N(n, fmt, ...) \ > > + pr_level(n, fmt, ##__VA_ARGS__) > > +#define pr(fmt, ...) pr_N(1, pr_fmt(fmt), ##__VA_ARGS__) > > + > > +static int pr_time(const char *str, u64 time) > > +{ > > + u64 secs, usecs, nsecs = time; > > + > > + secs = nsecs / NSECS_PER_SEC; > > + nsecs -= secs * NSECS_PER_SEC; > > + usecs = nsecs / NSECS_PER_USEC; > > + return fprintf(stderr, "\t[%13lu.%06lu] %s\n", secs, usecs, str); > > +} > > It'd be better if these functions somehow reuse existing pr_* functions > or at least honor the use_browser value IMHO.
I wanted to separate this output so I could have it not mixed with standard debug messages.. it could get messy
I was thinking maybe we want some smart debug/verbose system that would allow this.. separate debug messages based on the config/subsystem/option/objects/whatever implemented via generic code
thanks, jirka -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |