Messages in this thread Patch in this message | | | Date | Wed, 11 Jun 2014 09:22:38 -0700 | From | Christoph Hellwig <> | Subject | Re: Phantom ACL-related xattrs on 3.14.4 NFS client |
| |
On Wed, Jun 11, 2014 at 09:15:18AM -0700, Philippe Troin wrote: > So, the only regression remaining between 3.13.11 and 3.14.6 + your > patch is the one where listxattr(2) and friends do not NUL-terminate the > xattr names they return. This is detailed in > <1402435203.24047.9.camel@ceramic.home.fifi.org> I sent yesterday.
Oh, that's a bug in my patch. The following incremental patch should fix it:
diff --git a/fs/nfs/nfs3acl.c b/fs/nfs/nfs3acl.c index e083827..8f854dd 100644 --- a/fs/nfs/nfs3acl.c +++ b/fs/nfs/nfs3acl.c @@ -262,6 +262,7 @@ nfs3_list_one_acl(struct inode *inode, int type, const char *name, void *data, posix_acl_release(acl); *result += strlen(name); + *result += 1; if (!size) return 0; if (*result > size)
| |