lkml.org 
[lkml]   [2014]   [Jun]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.13 002/160] HID: core: do not scan constant input report
    Date
    3.13.11.3 -stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Benjamin Tissoires <benjamin.tissoires@redhat.com>

    commit e24d0d399b2fce71b627043e900ef28283850482 upstream.

    The Microsoft Surface Type/Touch Cover 2 is a fancy device which advertised
    itself as a multitouch device but with constant input reports.
    This way, hid_scan_report() gives the group MULTITOUCH to it, but
    hid-multitouch can not handle it due to the constant collection ignored
    by hid-input.

    To prevent such crap in the future, and while we do not fix this particular
    device, make the scan_report coherent with hid-input.c, and ignore constant
    input reports.

    Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
    Signed-off-by: Jiri Kosina <jkosina@suse.cz>
    Signed-off-by: Kamal Mostafa <kamal@canonical.com>
    ---
    drivers/hid/hid-core.c | 3 +++
    1 file changed, 3 insertions(+)

    diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c
    index 253fe23..12f1a45 100644
    --- a/drivers/hid/hid-core.c
    +++ b/drivers/hid/hid-core.c
    @@ -718,6 +718,9 @@ static int hid_scan_main(struct hid_parser *parser, struct hid_item *item)
    case HID_MAIN_ITEM_TAG_END_COLLECTION:
    break;
    case HID_MAIN_ITEM_TAG_INPUT:
    + /* ignore constant inputs, they will be ignored by hid-input */
    + if (data & HID_MAIN_ITEM_CONSTANT)
    + break;
    for (i = 0; i < parser->local.usage_index; i++)
    hid_scan_input_usage(parser, parser->local.usage[i]);
    break;
    --
    1.9.1


    \
     
     \ /
      Last update: 2014-06-10 23:21    [W:5.301 / U:0.236 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site