Messages in this thread | | | From | Prabhakar Lad <> | Date | Tue, 10 Jun 2014 17:35:28 +0100 | Subject | Re: [PATCH] media: v4l2-core: v4l2-dv-timings.c: Cleaning up code that putting values to the same variable twice |
| |
Hi Rickard,
Thanks for the patch.
On Sat, Jun 7, 2014 at 1:31 AM, Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se> wrote: > Instead of putting the same variable twice, > was rather intended to set this value to two different variable. > > This was partly found using a static code analysis program called cppcheck. > > Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
The commit message and header needs to be improved, apart from that rest of the patch looks good.
Acked-by: Lad, Prabhakar <prabhakar.csengg@gmail.com>
Regards, --Prabhakar Lad
> --- > drivers/media/v4l2-core/v4l2-dv-timings.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/media/v4l2-core/v4l2-dv-timings.c b/drivers/media/v4l2-core/v4l2-dv-timings.c > index 48b20df..eb3850c 100644 > --- a/drivers/media/v4l2-core/v4l2-dv-timings.c > +++ b/drivers/media/v4l2-core/v4l2-dv-timings.c > @@ -599,10 +599,10 @@ struct v4l2_fract v4l2_calc_aspect_ratio(u8 hor_landscape, u8 vert_portrait) > aspect.denominator = 9; > } else if (ratio == 34) { > aspect.numerator = 4; > - aspect.numerator = 3; > + aspect.denominator = 3; > } else if (ratio == 68) { > aspect.numerator = 15; > - aspect.numerator = 9; > + aspect.denominator = 9; > } else { > aspect.numerator = hor_landscape + 99; > aspect.denominator = 100; > -- > 1.7.10.4 >
| |