Messages in this thread | | | Date | Tue, 10 Jun 2014 17:43:23 +0300 | From | Stratos Karafotis <> | Subject | Re: [PATCH 6/7] cpufreq: intel_pstate: Trivial code cleanup |
| |
On 10/06/2014 12:22 πμ, Joe Perches wrote: > On Tue, 2014-06-10 at 00:01 +0300, Stratos Karafotis wrote: >> Remove unnecessary braces. > > [] > >> @@ -204,20 +203,16 @@ static inline void intel_pstate_busy_pid_reset(struct cpudata *cpu) > >> static inline void intel_pstate_reset_all_pid(void) >> { >> unsigned int cpu; >> - for_each_online_cpu(cpu) { >> + >> + for_each_online_cpu(cpu) >> if (all_cpu_data[cpu]) >> intel_pstate_busy_pid_reset(all_cpu_data[cpu]); >> - } > > It's pretty traditional to keep the braces here > as it generally makes it clearer for the reader. > > for (...) { > if (foo) > bar(); > } > > is generally used over > > for (...) > if (foo) > bar(); > > Just like using > > if (foo) { > /* commment */ > bar(); > }
OK, I will revert these changes in v2.
>> @@ -748,15 +744,14 @@ static int intel_pstate_init_cpu(unsigned int cpunum) > [] >> - pr_info("Intel pstate controlling: cpu %d\n", cpunum); >> + pr_info("Intel pstate controlling: CPU %d\n", cpunum); > > cpu is very slightly preferred lower case. > > $ git grep -E -i '^[^"]*"[^"]*\bcpu\b'|grep -w -i -o cpu | sort |uniq -c | sort -rn > 2705 cpu > 2084 CPU > 17 Cpu >
Although, I believe that the term 'CPU' is more appropriate, I'll revert this as the majority and Dirk prefer it. :)
Thanks for your comments! Stratos
-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |