lkml.org 
[lkml]   [2014]   [May]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] drivers: staging: ft1000: Improve coding style
From
Date
On Sat, 2014-05-10 at 09:53 +0300, Artem Fetishev wrote:
> Improvements include:
> - Lines over 80 characters;
> - Use pr_info() instead printk(KERN_INFO);
> - Removal of typedefs;
> - Indentation.
> - Fix IOCTL_FT1000_* marcos:
> - Add closing brackets;
> - remove sizeof (_IOR and _IOW macro can accept types);
> - replace _IOW which size of 0 (the last arg) with _IO.
> - Actually these macros are not used anywhere and might be removed.

Hello Artem.

All of these are nice little fixes, but combined,
they are difficult to review.

Could you please separate them into multiple patches,
one per line item entry?

Maybe reorder them too doing the indentation fix
first and leaving the 80 column changes until last.



\
 
 \ /
  Last update: 2014-05-09 23:01    [W:0.036 / U:0.760 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site