Messages in this thread | | | Date | Fri, 09 May 2014 11:03:58 -0400 | From | Rik van Riel <> | Subject | Re: [PATCH 2/4] sched,numa: weigh nearby nodes for task placement on complex NUMA topologies |
| |
On 05/09/2014 06:13 AM, Peter Zijlstra wrote: > On Thu, May 08, 2014 at 01:23:29PM -0400, riel@redhat.com wrote: >> This patch does nothing on machines with simple NUMA topologies. > > Was this: > >> + /* >> + * No need to calculate a score if the system has a simple NUMA >> + * topology, with no node distances between "local" and "far away". >> + */ >> + if (max_distance == LOCAL_DISTANCE) >> + return 0; > > Supposed to make that true? > > It doesn't. That test is a !numa test, not a fully connected test. >
Look at patch 1/4. I only set max_distance to !LOCAL_DISTANCE if the system has multiple different distances in the SLIT table.
I guess that needs to be cleaned up :)
| |