Messages in this thread | | | Date | Fri, 9 May 2014 09:33:18 -0400 | From | Don Zickus <> | Subject | Re: [PATCHSET 00/17] perf report: Add -F option for specifying output fields (v4) |
| |
On Fri, May 09, 2014 at 03:11:28PM +0900, Namhyung Kim wrote: > >> > I am willing to believe I missed scenario when sorting, I just can't think > >> > of it (so I wouldn't know how to fix it). That's why I was looking for an > >> > example to make it more obvious to me. Sorry for being slow.. > >> > >> I'm also sorry for being late. Looking at the code, it seems to use > >> identity__map_ip() for anon maps so my concern is bogus. Please just > >> forget about it and keep going. Sorry for interrupting your work.. > > > > No worries. Always good to have an extra pair of eyes. > > > > I am a little stuck about where to go. I think it might make sense to > > submit this as a standalone patch (despite the possible group limitation > > we are discussing). Thoughts? > > You meant to submit the 'dcacheline' sort key patch? I'm okay with it.
Ok. I'll try to put together a patchset next week for that piece.
> > Things are getting more confusing when thinking about complex > scenarios.. so I'd rather finish this -F option patchset and start to > think about how to integrate group sorting with it.
Hehe. I understand. That's fine.
Cheers, Don
| |