lkml.org 
[lkml]   [2014]   [May]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Staging: gdm72xx Fix minor coding style problems
On Thu, May 08, 2014 at 11:53:57AM +0530, Adithya K wrote:
> This is patch for fixing of minor coding style problems.
>
> Signed-off-by: Adithya K <linux.challenge1@gmail.com>
> ---
> drivers/staging/gdm72xx/gdm_qos.c | 3 ++-
> drivers/staging/gdm72xx/gdm_sdio.c | 1 +
> drivers/staging/gdm72xx/gdm_usb.c | 2 +-
> drivers/staging/gdm72xx/gdm_wimax.c | 3 +++
> drivers/staging/gdm72xx/usb_boot.c | 1 +
> 5 files changed, 8 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/gdm72xx/gdm_qos.c b/drivers/staging/gdm72xx/gdm_qos.c
> index 50d43ad..5ed32b9 100644
> --- a/drivers/staging/gdm72xx/gdm_qos.c
> +++ b/drivers/staging/gdm72xx/gdm_qos.c
> @@ -229,6 +229,7 @@ static u32 extract_qos_list(struct nic *nic, struct list_head *head)
> entry = list_entry(
> qcb->qos_list[i].prev,
> struct qos_entry_s, list);
> +
> list_move_tail(&entry->list, head);
> qcb->csr[i].qos_buf_count++;
>

This one is wrong. It's not something I care about but since the patch
needs to be redone, then please leave it out.

> diff --git a/drivers/staging/gdm72xx/gdm_usb.c b/drivers/staging/gdm72xx/gdm_usb.c
> index 20539d8..8fd1b1f 100644
> --- a/drivers/staging/gdm72xx/gdm_usb.c
> +++ b/drivers/staging/gdm72xx/gdm_usb.c
> @@ -759,7 +759,7 @@ static int k_mode_thread(void *arg)
> spin_lock_irqsave(&k_lock, flags2);
> }
> wait_event_interruptible_lock_irq(k_wait,
> - !list_empty(&k_list) || k_mode_stop,
> + !list_empty(&k_list) || k_mode_stop,
> k_lock);
> spin_unlock_irqrestore(&k_lock, flags2);
> }

This one is totally wrong. Please resend withouth this chunk.

regards,
dan carpenter



\
 
 \ /
  Last update: 2014-05-08 10:21    [W:0.030 / U:1.748 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site