Messages in this thread | | | Date | Thu, 8 May 2014 11:25:34 +0530 | Subject | Re: [PATCH 1/3] PM / OPP: Add support for descending order for cpufreq table | From | Viresh Kumar <> |
| |
On 8 May 2014 07:37, Jonghwan Choi <jhbird.choi@samsung.com> wrote:
As asked earlier by Nishanth:
- Avoid top-posting (the practice of putting your answer above the quoted text you are responding to). It makes your response harder to read and makes a poor impression.
Reference: Documentation/development-process/2.Process
> I believe that 3 item is required for DVFS. Those are frequency, voltage, divider value.
Not necessarily. People may need a multiplier as well or some other configuration and so this stuff was left for drivers to implement.
> How about adding that divider value into struct dev_pm_opp like this;
Wouldn't work for all and so NAK.
> struct dev_pm_opp { > struct list_head node; > > bool available; > unsigned long rate; > unsigned long u_volt; > unsigned int ctl[2]; // Added > > struct device_opp *dev_opp; > struct rcu_head head; > };
Always paste a diff, its impossible to read this :(
> In my test, it works very wel..
Working isn't enough :)
You don't have a complicated list of dividers, these are simple values from 0 to total-num-of-freq -1 and that can be handled very easily in your code.. Please do it there.
| |