Messages in this thread | | | Date | Wed, 7 May 2014 15:34:03 -0700 | From | Andrew Morton <> | Subject | Re: [PATCH 1/1] kernel/res_counter.c: replace simple_strtoull by kstrtoull |
| |
On Wed, 7 May 2014 22:37:32 +0200 Fabian Frederick <fabf@skynet.be> wrote:
> --- a/kernel/res_counter.c > +++ b/kernel/res_counter.c > @@ -183,11 +183,12 @@ int res_counter_memparse_write_strategy(const char *buf, > { > char *end; > unsigned long long res; > + int rc; > > /* return RES_COUNTER_MAX(unlimited) if "-1" is specified */ > if (*buf == '-') { > - res = simple_strtoull(buf + 1, &end, 10); > - if (res != 1 || *end != '\0') > + rc = kstrtoull(buf + 1, 10, &res);
There's no need to give `rc' function-wide scope.
int rc = kstrtoull(buf + 1, 10, &res);
will work here.
> + if ((res != 1) || (rc))
And that's over-parenthesized.
> return -EINVAL; > *resp = RES_COUNTER_MAX; > return 0;
| |