lkml.org 
[lkml]   [2014]   [May]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 4/5] KVM: x86: Wrong register masking in 64-bit mode
Il 07/05/2014 16:50, Bandan Das ha scritto:
>> > +static void assign_masked(ulong *dest, ulong src, int bytes)
>> > {
>> > - *dest = (*dest & ~mask) | (src & mask);
>> > + switch (bytes) {
>> > + case 2:
>> > + *dest = (u16)src | (*dest & ~0xfffful);
>> > + break;
>> > + case 4:
>> > + *dest = (u32)src;
>> > + break;
>> > + case 8:
>> > + *dest = src;
>> > + break;
>> > + default:
>> > + BUG();
> IIRC, Paolo mentioned that a WARN() is preferable. But I see
> a lot other places where BUG() is called, maybe, he can confirm.
>

There is really no reason to crash the host for a misused API, so I do
believe that a WARN() is preferable.

Paolo


\
 
 \ /
  Last update: 2014-05-08 00:21    [W:0.059 / U:0.488 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site