Messages in this thread Patch in this message | | | From | Rob Herring <> | Subject | [PATCH 2/4] of/platform: return error on of_platform_device_create_pdata failure | Date | Wed, 7 May 2014 16:48:16 -0500 |
| |
From: Rob Herring <robh@kernel.org>
of_platform_populate does not return an error if creating the platform device fails. This means almost any error from driver core cannot be detected by the caller. Fix this.
Signed-off-by: Rob Herring <robh@kernel.org> --- drivers/of/platform.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/of/platform.c b/drivers/of/platform.c index 404d1da..622aeb3 100644 --- a/drivers/of/platform.c +++ b/drivers/of/platform.c @@ -391,7 +391,9 @@ static int of_platform_bus_create(struct device_node *bus, } dev = of_platform_device_create_pdata(bus, bus_id, platform_data, parent); - if (!dev || !of_match_node(matches, bus)) + if (!dev) + return -ENODEV; + if (!of_match_node(matches, bus)) return 0; for_each_child_of_node(bus, child) { -- 1.9.1
| |