lkml.org 
[lkml]   [2014]   [May]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] Fixing Coding style Warnings in file drivers/staging/comedi/drivers/das08.h
From
Date
On Tue, 2014-05-06 at 14:54 +0530, Sheetal Tigadoli wrote:
> This patch fixes coding style warnings such as 'lines exceeding 80 characters limit' &
> 'lines begining with space character', in file drivers/staging/comedi/drivers/das08.h

This is poor patch subject style.
Please use "[PATCH] subsystem: description" style.

> This patch is sent to complete one of Eudyptula Challenges

Please do not include any "Eudyptula Challenge" line
in the commit log.

> diff --git a/drivers/staging/comedi/drivers/das08.h b/drivers/staging/comedi/drivers/das08.h
[]
> @@ -50,7 +49,8 @@ struct das08_board_struct {
> struct i8254_struct {
> - int channels; /* available channels. Some could be used internally. */
> + int channels; /* available channels. Some could be used
> + internally. */

Multiline comment style should use
/*
* comment lines
* ...
*/




\
 
 \ /
  Last update: 2014-05-07 23:01    [W:0.033 / U:0.600 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site