Messages in this thread | | | Date | Wed, 07 May 2014 10:14:16 -0700 | From | "H. Peter Anvin" <> | Subject | Re: [PATCH v3] x86/iosf: Make IOSF driver modular and usable by more drivers |
| |
On 05/07/2014 10:10 AM, One Thousand Gnomes wrote: > On Wed, 07 May 2014 10:04:56 -0700 > "H. Peter Anvin" <hpa@zytor.com> wrote: > >> On 05/07/2014 09:48 AM, One Thousand Gnomes wrote: >>> On Fri, 2 May 2014 10:36:39 -0700 >>>> +bool iosf_mbi_available(void) >>>> +{ >>>> + return mbi_pdev; >>>> +} >>>> +EXPORT_SYMBOL(iosf_mbi_available); >>> >>> Probably worth a follow up patch that comments this so the assumption >>> that iosf can never be unloaded or hot-unplugged is clear. >>> >> >> When you say unloaded you mean the module or the hardware? > > Both. Currently the hardware isn't removable (but could be virtually > removed by playing with unplugging) and the module can't be unloaded so > the assumption is fine. >
I guess I don't see why the module isn't removable. Of course, any driver which calls iosf_mbi_available() will depend on it, preventing removal until *those* modules have been removed...
-hpa
| |