Messages in this thread | | | From | Rusty Russell <> | Subject | Re: [PATCH] kmod: Pass usermodehelper "-b" to use blacklist commands | Date | Wed, 07 May 2014 10:53:37 +0930 |
| |
Andrew Morton <akpm@linux-foundation.org> writes: > On Tue, 6 May 2014 19:31:36 +0200 Oleg Nesterov <oleg@redhat.com> wrote: > >> On 05/06, Kirill Tkhai wrote: >> > >> > User may want to prohibit autoloading of some modules, >> > which happens when someone in kernel calls request_module(). >> > >> > For comparison, udev considers blacklist even if corresponding >> > hardware presents in the system. In-kernel request_module() >> > functionality is rather similar to udev's, so user may want >> > to disallow it too. >> >> Personally, I am always nervous (perhaps too much) when it comes to the >> user-visible changes like this. >> >> And if a user/distro wants "-b" it can create a simple script which just >> execs /sbin/modprobe with "-b" and overwrite /proc/sys/kernel/modprobe. >> >> OTOH. What if /proc/sys/kernel/modprobe points to a binary which is not >> /sbin/modprobe and doesn't expect "-b" ? This can break things. >> > > Yup. Perhaps the kernel should provide modprobe with a reliable way of > knowing "you were called by the kernel" (if there isn't presently a > way) and let modprobe work out what to do.
Indeed, this is a non-starter.
Cheers, Rusty.
| |