Messages in this thread Patch in this message | | | From | Joonsoo Kim <> | Subject | [PATCH v2 03/10] slab: move up code to get kmem_cache_node in free_block() | Date | Wed, 7 May 2014 15:06:13 +0900 |
| |
node isn't changed, so we don't need to retreive this structure everytime we move the object. Maybe compiler do this optimization, but making it explicitly is better.
Acked-by: Christoph Lameter <cl@linux.com> Signed-off-by: Joonsoo Kim <iamjoonsoo.kim@lge.com>
diff --git a/mm/slab.c b/mm/slab.c index e2c80df..92d08e3 100644 --- a/mm/slab.c +++ b/mm/slab.c @@ -3340,7 +3340,7 @@ static void free_block(struct kmem_cache *cachep, void **objpp, int nr_objects, int node) { int i; - struct kmem_cache_node *n; + struct kmem_cache_node *n = cachep->node[node]; for (i = 0; i < nr_objects; i++) { void *objp; @@ -3349,7 +3349,6 @@ static void free_block(struct kmem_cache *cachep, void **objpp, int nr_objects, objp = clear_obj_pfmemalloc(objpp[i]); page = virt_to_head_page(objp); - n = cachep->node[node]; list_del(&page->lru); check_spinlock_acquired_node(cachep, node); slab_put_obj(cachep, page, objp, node); -- 1.7.9.5
| |