lkml.org 
[lkml]   [2014]   [May]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 02/26] ARM: OMAP: dmtimer: Add comments on OMAP1 clock framework
* Joel Fernandes <joelf@ti.com> [140424 14:44]:
> OMAP1 doesn't support clock framework, add a comment where needed
> and correct a FIXME.

This is at least a wrong comment, the original comment seems right
to me.

Tony

> Signed-off-by: Joel Fernandes <joelf@ti.com>
> ---
> arch/arm/plat-omap/dmtimer.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/plat-omap/dmtimer.c b/arch/arm/plat-omap/dmtimer.c
> index ecd3f97..f5a674c 100644
> --- a/arch/arm/plat-omap/dmtimer.c
> +++ b/arch/arm/plat-omap/dmtimer.c
> @@ -142,8 +142,7 @@ static int omap_dm_timer_prepare(struct omap_dm_timer *timer)
> int rc;
>
> /*
> - * FIXME: OMAP1 devices do not use the clock framework for dmtimers so
> - * do not call clk_get() for these devices.
> + * Do not call clk_get() for OMAP1 due to no clock framework support.
> */
> if (!(timer->capability & OMAP_TIMER_NEEDS_RESET)) {
> timer->fclk = clk_get(&timer->pdev->dev, "fck");
> @@ -461,6 +460,7 @@ int omap_dm_timer_stop(struct omap_dm_timer *timer)
> if (unlikely(!timer))
> return -EINVAL;
>
> + /* OMAP1 is not converted to clk framework so avoid clk_get_rate here */
> if (!(timer->capability & OMAP_TIMER_NEEDS_RESET))
> rate = clk_get_rate(timer->fclk);
>
> --
> 1.7.9.5
>


\
 
 \ /
  Last update: 2014-05-07 17:41    [W:0.266 / U:0.196 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site