Messages in this thread | | | Date | Wed, 7 May 2014 08:20:04 -0700 | From | Tony Lindgren <> | Subject | Re: [PATCH 02/26] ARM: OMAP: dmtimer: Add comments on OMAP1 clock framework |
| |
* Joel Fernandes <joelf@ti.com> [140424 14:44]: > OMAP1 doesn't support clock framework, add a comment where needed > and correct a FIXME.
This is at least a wrong comment, the original comment seems right to me.
Tony
> Signed-off-by: Joel Fernandes <joelf@ti.com> > --- > arch/arm/plat-omap/dmtimer.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm/plat-omap/dmtimer.c b/arch/arm/plat-omap/dmtimer.c > index ecd3f97..f5a674c 100644 > --- a/arch/arm/plat-omap/dmtimer.c > +++ b/arch/arm/plat-omap/dmtimer.c > @@ -142,8 +142,7 @@ static int omap_dm_timer_prepare(struct omap_dm_timer *timer) > int rc; > > /* > - * FIXME: OMAP1 devices do not use the clock framework for dmtimers so > - * do not call clk_get() for these devices. > + * Do not call clk_get() for OMAP1 due to no clock framework support. > */ > if (!(timer->capability & OMAP_TIMER_NEEDS_RESET)) { > timer->fclk = clk_get(&timer->pdev->dev, "fck"); > @@ -461,6 +460,7 @@ int omap_dm_timer_stop(struct omap_dm_timer *timer) > if (unlikely(!timer)) > return -EINVAL; > > + /* OMAP1 is not converted to clk framework so avoid clk_get_rate here */ > if (!(timer->capability & OMAP_TIMER_NEEDS_RESET)) > rate = clk_get_rate(timer->fclk); > > -- > 1.7.9.5 >
| |