| Date | Wed, 7 May 2014 16:55:53 +0200 | From | Michal Hocko <> | Subject | Re: [patch 4/9] mm: memcontrol: catch root bypass in move precharge |
| |
On Wed 30-04-14 16:25:38, Johannes Weiner wrote: [...] > @@ -6546,8 +6546,9 @@ one_by_one: > cond_resched(); > } > ret = mem_cgroup_try_charge(memcg, GFP_KERNEL, 1, false); > + if (ret == -EINTR) > + __mem_cgroup_cancel_charge(root_mem_cgroup, 1); > if (ret) > - /* mem_cgroup_clear_mc() will do uncharge later */
I would prefer to keep the comment and explain that we will loose return code on the way and that is why cancel on root has to be done here.
> return ret; > mc.precharge++; > } > -- > 1.9.2 >
-- Michal Hocko SUSE Labs
|