lkml.org 
[lkml]   [2014]   [May]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] plist: replace pr_debug with printk in plist_test()
On Wed, 7 May 2014 10:21:28 -0400
Dan Streetman <ddstreet@ieee.org> wrote:


> It would be even better if the note could clarify that sometimes it is
> ok to use printk(KERN_DEBUG

Exactly. I think it's rather stupid to have to do a #define DEBUG to
have pr_debug() print in general.

I see no reason to have pr_debug() be anything different than the other
pr_*() functions. Perhaps the pr_debug() should have been called
debug_print(), or dyn_print(), where it can be dynamic printk or
enabled with a DEBUG macro.

The plist code is a perfect scenario where printk(KERN_DEBUG...) is
appropriate, and using pr_debug() with a hard coded #define DEBUG is
just stupid.

-- Steve


\
 
 \ /
  Last update: 2014-05-07 17:21    [W:0.070 / U:0.104 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site