Messages in this thread | | | Date | Wed, 7 May 2014 10:45:39 +0100 | From | Markos Chandras <> | Subject | Re: [PATCH] MIPS: Introduce the use of the managed version of kzalloc |
| |
Hi,
On 05/07/2014 05:43 AM, Himangi Saraogi wrote: > This patch moves data allocated using kzalloc to managed data allocated > using devm_kzalloc and cleans now unnecessary kfrees in probe and remove > functions.The labels out and out_mem are also removed as they are no > longer required. > > The following Coccinelle semantic patch was used for making the change: > [..] > > Signed-off-by: Himangi Saraogi <himangi774@gmail.com> > --- > arch/mips/mti-sead3/sead3-i2c-drv.c | 37 ++++++++++++++----------------------- > 1 file changed, 14 insertions(+), 23 deletions(-) > > diff --git a/arch/mips/mti-sead3/sead3-i2c-drv.c b/arch/mips/mti-sead3/sead3-i2c-drv.c > index 1f787a6..4d72e0e 100644 > --- a/arch/mips/mti-sead3/sead3-i2c-drv.c > +++ b/arch/mips/mti-sead3/sead3-i2c-drv.c > @@ -304,22 +304,18 @@ static int sead3_i2c_platform_probe(struct platform_device *pdev) > int ret; >[...] > - return ret; > + if (ret) > + return ret; > + ^^^^ trailing whitespace
Apart from that, the patch seems to be ok. Thanks!
Tested-by: Markos Chandras <markos.chandras@imgtec.com> Reviewed-by: Markos Chandras <markos.chandras@imgtec.com>
-- markos
| |