Messages in this thread | | | Subject | Re: [PATCH] libata-sff: remove dead code | From | Paul Bolle <> | Date | Wed, 07 May 2014 11:23:24 +0200 |
| |
[Added David.]
On Tue, 2014-05-06 at 22:26 +0100, Alan Cox wrote: > On Sun, 2014-05-04 at 13:50 +0200, Paul Bolle wrote: > > Ever since v2.6.19 the code contains a check for CONFIG_NO_ATA_LEGACY. > > But that macro has never been defined. Apparently no one ran into > > problems on platforms that do not support compatibility mode. > > It was needed for some of the FRV devices I belive. Please check with > David Howells if it's still relevant
This code has been behind (effectively) an "#if 0" check for seven years. So either there was no problem to begin with, the problem is fixed somewhere else, or no one is actually using the affected devices. So I doubt this is still relevant. But maybe David thinks otherwise...
> (even if its not used in the default configs)
It's not used (and has never been used) regardless which config one tries.
Paul Bolle
| |