Messages in this thread | | | Date | Mon, 05 May 2014 13:16:52 -0700 | From | John Stultz <> | Subject | Re: [PATCH 1/4] printk: Re-add irqsave/restore in printk_sched |
| |
On 05/04/2014 09:13 AM, Peter Zijlstra wrote: > On Sun, May 04, 2014 at 04:58:47PM +0200, Jan Kara wrote: >> On Fri 02-05-14 15:09:15, John Stultz wrote: >>> A commit in akpm's tree (printk: remove separate printk_sched >>> buffers...), removed the printk_sched irqsave/restore lines >>> since it was safe for current users. Since we may be expanding >>> usage of printk_sched(), re-add the irqsave/restore logic >>> to make the functionality more generally safe. >> So I'm just wondering: Do you have anything particular for which you need >> interrupts disabled? Won't e.g. disabling preemption be enough? > Yeah, I think preemption disabled is sufficient.
Ok, will change this and resend.
thanks -john
| |