lkml.org 
[lkml]   [2014]   [May]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 3/3] regulator: Add LTC3589 support
From
Date
Am Donnerstag, den 01.05.2014, 11:07 -0700 schrieb Mark Brown:
> On Tue, Apr 29, 2014 at 06:37:10PM +0200, Philipp Zabel wrote:
> > This patch adds support for the Linear Technology LTC3589, LTC3589-1,
> > and LTC3589-2 8-output I2C voltage regulator ICs.
>
> One small nit in addition to the vendor prefix thing:
>
> > +static const int ltc3589_12_ldo4[] = {
> > + 1200000, 1800000, 2500000, 3200000,
> > +};
>
> This could use regulator_map_voltage_ascend(), though for all practical
> purposes the table is so small it makes no meaningful difference.

The table for the LTC3589-without-1/2 variant is not ascending.
If it makes no difference, I'd prefer to use the same ops for both.

regards
Philipp



\
 
 \ /
  Last update: 2014-05-05 10:01    [W:0.080 / U:1.048 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site