Messages in this thread | | | Date | Mon, 05 May 2014 17:32:07 +0200 | From | Tomasz Nowicki <> | Subject | Re: [PATCH 1/7] apei, mce: Call MCE-specific code only for X86 architecture. |
| |
On 05.05.2014 16:53, Borislav Petkov wrote: > On Mon, May 05, 2014 at 04:34:41PM +0200, Tomasz Nowicki wrote: >> acpi_disable_cmcff as global value can switch off/on MC entries >> analysing via kernel args. > > No, it switches off firmware first mode for correctable errors because > of buggy BIOSes - 9ad95879cd1b2 (what else...) > >> This glob value resides in x86 ACPI code and has meaning only for MCE >> related mechanism, > > Of course it doesn't! > >> that is why I have moved it under hest_parse_cmc. > > See APEI section in the ACPI spec "18.4 Firmware First Error Handling." > > Regardless of what your version of APEI does, you actually shouldn't > need to touch acpi_disable_cmcff at all as it not arch-specific. >
You are right! I will fix that big misunderstanding from my side in next patch version.
Thanks, Tomasz
| |