lkml.org 
[lkml]   [2014]   [May]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.14 144/158] ocfs2: fix panic on kfree(xattr->name)
    Date
    3.14-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>

    commit f81c20158f8d5f7938d5eb86ecc42ecc09273ce6 upstream.

    Commit 9548906b2bb7 ('xattr: Constify ->name member of "struct xattr"')
    missed that ocfs2 is calling kfree(xattr->name). As a result, kernel
    panic occurs upon calling kfree(xattr->name) because xattr->name refers
    static constant names. This patch removes kfree(xattr->name) from
    ocfs2_mknod() and ocfs2_symlink().

    Signed-off-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
    Reported-by: Tariq Saeed <tariq.x.saeed@oracle.com>
    Tested-by: Tariq Saeed <tariq.x.saeed@oracle.com>
    Reviewed-by: Srinivas Eeda <srinivas.eeda@oracle.com>
    Cc: Joel Becker <jlbec@evilplan.org>
    Cc: Mark Fasheh <mfasheh@suse.com>
    Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
    Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    fs/ocfs2/namei.c | 2 --
    1 file changed, 2 deletions(-)

    --- a/fs/ocfs2/namei.c
    +++ b/fs/ocfs2/namei.c
    @@ -450,7 +450,6 @@ leave:

    brelse(new_fe_bh);
    brelse(parent_fe_bh);
    - kfree(si.name);
    kfree(si.value);

    ocfs2_free_dir_lookup_result(&lookup);
    @@ -1855,7 +1854,6 @@ bail:

    brelse(new_fe_bh);
    brelse(parent_fe_bh);
    - kfree(si.name);
    kfree(si.value);
    ocfs2_free_dir_lookup_result(&lookup);
    if (inode_ac)



    \
     
     \ /
      Last update: 2014-05-04 19:41    [W:3.566 / U:0.000 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site