lkml.org 
[lkml]   [2014]   [May]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.14 026/158] ALSA: hda - Fix silent speaker output due to mute LED fixup
    Date
    3.14-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Takashi Iwai <tiwai@suse.de>

    commit 415d555e6b398b00fc1733f0113065a54df9106a upstream.

    The recent fixups for HP laptops to support the mute LED made the
    speaker output silent on some machines. It turned out that they use
    the NID 0x18 for the speaker while it's also used for controlling the
    LED via VREF bits although the current driver code blindly assumes
    that such a node is a mic pin (where 0x18 is usually so).

    This patch fixes the problem by only changing the VREF bits and
    keeping the other pin ctl bits.

    Reported-and-tested-by: Hui Wang <hui.wang@canonical.com>
    Signed-off-by: Takashi Iwai <tiwai@suse.de>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    sound/pci/hda/patch_realtek.c | 5 +++--
    1 file changed, 3 insertions(+), 2 deletions(-)

    --- a/sound/pci/hda/patch_realtek.c
    +++ b/sound/pci/hda/patch_realtek.c
    @@ -3212,8 +3212,9 @@ static void alc269_fixup_mic_mute_hook(v

    if (spec->mute_led_polarity)
    enabled = !enabled;
    - pinval = AC_PINCTL_IN_EN |
    - (enabled ? AC_PINCTL_VREF_HIZ : AC_PINCTL_VREF_80);
    + pinval = snd_hda_codec_get_pin_target(codec, spec->mute_led_nid);
    + pinval &= ~AC_PINCTL_VREFEN;
    + pinval |= enabled ? AC_PINCTL_VREF_HIZ : AC_PINCTL_VREF_80;
    if (spec->mute_led_nid)
    snd_hda_set_pin_ctl_cache(codec, spec->mute_led_nid, pinval);
    }



    \
     
     \ /
      Last update: 2014-05-04 19:41    [W:4.241 / U:0.024 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site