lkml.org 
[lkml]   [2014]   [May]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.14 147/158] block: Fix for_each_bvec()
    Date
    3.14-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: "Martin K. Petersen" <martin.petersen@oracle.com>

    commit b7aa84d9cb9f26da1a9312c3e39dbd1a3c25a426 upstream.

    Commit 4550dd6c6b062 introduced for_each_bvec() which iterates over each
    bvec attached to a bio or bip. However, the macro fails to check bi_size
    before dereferencing which can lead to crashes while counting/mapping
    integrity scatterlist segments.

    Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
    Cc: Kent Overstreet <kmo@daterainc.com>
    Cc: Nicholas Bellinger <nab@linux-iscsi.org>
    Signed-off-by: Jens Axboe <axboe@fb.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    include/linux/bio.h | 6 +++---
    1 file changed, 3 insertions(+), 3 deletions(-)

    --- a/include/linux/bio.h
    +++ b/include/linux/bio.h
    @@ -216,9 +216,9 @@ static inline void bvec_iter_advance(str
    }

    #define for_each_bvec(bvl, bio_vec, iter, start) \
    - for ((iter) = start; \
    - (bvl) = bvec_iter_bvec((bio_vec), (iter)), \
    - (iter).bi_size; \
    + for (iter = (start); \
    + (iter).bi_size && \
    + ((bvl = bvec_iter_bvec((bio_vec), (iter))), 1); \
    bvec_iter_advance((bio_vec), &(iter), (bvl).bv_len))





    \
     
     \ /
      Last update: 2014-05-04 19:41    [W:4.044 / U:0.032 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site