Messages in this thread | | | Date | Sun, 4 May 2014 11:16:48 +0100 | From | Ian Abbott <> | Subject | Re: [PATCH] staging: comedi: ii_pci20kc: fix usage of uninit scalar in ii20k_attach() |
| |
On 04/05/14 01:26, Christian Engelmayer wrote: > This driver supports the PCI-20001C-1a and PCI-20001C-2a carrier boards. > The -2a version has 32 on-board DIO channels. In case this variant is > detected, local variable 'has_dio' is set accordingly. Otherwise it is > left uninitialized and the following subdevice instantiation depends on > the stack. Detected by Coverity - CID 1077830. > > Signed-off-by: Christian Engelmayer <cengelma@gmx.at> > --- > Compile tested and applies against branch staging-next of tree > git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git > --- > drivers/staging/comedi/drivers/ii_pci20kc.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/staging/comedi/drivers/ii_pci20kc.c b/drivers/staging/comedi/drivers/ii_pci20kc.c > index 3558ab3..2516ce8 100644 > --- a/drivers/staging/comedi/drivers/ii_pci20kc.c > +++ b/drivers/staging/comedi/drivers/ii_pci20kc.c > @@ -461,6 +461,7 @@ static int ii20k_attach(struct comedi_device *dev, > id = readb(devpriv->ioaddr + II20K_ID_REG); > switch (id & II20K_ID_MASK) { > case II20K_ID_PCI20001C_1A: > + has_dio = false; > break; > case II20K_ID_PCI20001C_2A: > has_dio = true; >
Thanks¬
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
-- -=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@mev.co.uk> )=- -=( Tel: +44 (0)161 477 1898 FAX: +44 (0)161 718 3587 )=- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |