lkml.org 
[lkml]   [2014]   [May]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH RFC - TAKE TWO - 02/12] block, bfq: add full hierarchical scheduling and cgroups support
    From
    Date

    Il giorno 30/mag/2014, alle ore 17:37, Tejun Heo <tj@kernel.org> ha scritto:

    > On Thu, May 29, 2014 at 11:05:33AM +0200, Paolo Valente wrote:
    >> diff --git a/include/linux/cgroup_subsys.h b/include/linux/cgroup_subsys.h
    >> index 768fe44..cdd2528 100644
    >> --- a/include/linux/cgroup_subsys.h
    >> +++ b/include/linux/cgroup_subsys.h
    >> @@ -39,6 +39,10 @@ SUBSYS(net_cls)
    >> SUBSYS(blkio)
    >> #endif
    >>
    >> +#if IS_ENABLED(CONFIG_CGROUP_BFQIO)
    >> +SUBSYS(bfqio)
    >> +#endif
    >
    > So, ummm, I don't think this is a good idea. Why aren't you plugging
    > into the blkcg infrastructure as cfq does? Why does it need to be a
    > separate controller?
    >

    It does not, actually. It is just that when we implemented that part, there was no blkcg infrastructure. After that, I have gone on experimenting with the low-latency heuristics and all the other stuff. Finally I have decided to first propose this new version of bfq, and then deal also with blkcg integration in case of a positive welcome.

    Thanks,
    Paolo

    > Thanks.
    >
    > --
    > tejun


    --
    Paolo Valente
    Algogroup
    Dipartimento di Fisica, Informatica e Matematica
    Via Campi, 213/B
    41125 Modena - Italy
    homepage: http://algogroup.unimore.it/people/paolo/



    \
     
     \ /
      Last update: 2014-05-31 00:41    [W:3.597 / U:0.044 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site