Messages in this thread | | | Date | Fri, 30 May 2014 11:01:03 -0600 | From | Bjorn Helgaas <> | Subject | Re: [PATCH] PCI, EDAC: fix ordering assign resource and bus_add |
| |
On Tue, May 07, 2013 at 04:29:31PM -0700, Yinghai Lu wrote: > We should assign unassigned resource before pci_bus_add_device. > > as late one will enable driver and create sysfs file that will need > pci io resources from assign unassigned code. > > Signed-off-by: Yinghai Lu <yinghai@kernel.org>
Applied to pci/resource for v3.16, thanks!
> --- > drivers/edac/i82875p_edac.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > Index: linux-2.6/drivers/edac/i82875p_edac.c > =================================================================== > --- linux-2.6.orig/drivers/edac/i82875p_edac.c > +++ linux-2.6/drivers/edac/i82875p_edac.c > @@ -293,13 +293,14 @@ static int i82875p_setup_overfl_dev(stru > if (dev == NULL) > return 1; > > + pci_bus_assign_resources(dev->bus); > + > err = pci_bus_add_device(dev); > if (err) { > i82875p_printk(KERN_ERR, > "%s(): pci_bus_add_device() Failed\n", > __func__); > } > - pci_bus_assign_resources(dev->bus); > } > > *ovrfl_pdev = dev;
| |