lkml.org 
[lkml]   [2014]   [May]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v4] NVMe: basic conversion to blk-mq
    On Thu, May 29, 2014 at 11:51:25PM +0200, Matias Bjørling wrote:
    > +static int nvme_init_hctx(struct blk_mq_hw_ctx *hctx, void *data,
    > + unsigned int i)
    > {
    > + struct nvme_dev *dev = data;
    > + struct nvme_queue *nvmeq = dev->queues[(i % dev->queue_count) + 1];
    > + BUG_ON(!nvmeq);
    > + WARN_ON(nvmeq->hctx);
    > + nvmeq->hctx = hctx;
    > + hctx->driver_data = nvmeq;
    > + return 0;
    > +}

    You can't call this parameter 'i'. See Documentation/CodingStyle chapter 4.
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2014-05-30 21:41    [W:4.348 / U:0.036 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site