lkml.org 
[lkml]   [2014]   [May]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/2] serial: imx: disable the receiver ready interrupt for imx_stop_rx
On 23.05.2014 06:32, Huang Shijie wrote:
> This patch disables the receiver ready interrupt for imx_stop_rx.
> It reduces the interrupt numbers when the uart is going to close
> or suspend.
>
> Signed-off-by: Huang Shijie <b32955@freescale.com>
> ---
> drivers/tty/serial/imx.c | 4 ++++
> 1 files changed, 4 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/tty/serial/imx.c b/drivers/tty/serial/imx.c
> index ed6cdf7..6026101 100644
> --- a/drivers/tty/serial/imx.c
> +++ b/drivers/tty/serial/imx.c
> @@ -440,6 +440,10 @@ static void imx_stop_rx(struct uart_port *port)
>
> temp = readl(sport->port.membase + UCR2);
> writel(temp & ~UCR2_RXEN, sport->port.membase + UCR2);
> +
> + /* disable the `Receiver Ready Interrrupt` */
> + temp = readl(sport->port.membase + UCR1);
> + writel(temp & ~UCR1_RRDYEN, sport->port.membase + UCR1);

Will this change cause a loss or a processing delay of RX characters
pending in the RX FIFO ?

It is not clear whether disabling the receiver will clear the RX FIFO.
My guess is that the contents of the RX FIFO will remain intact when
the receiver is disabled. The RX interrupt has an opportunity to mop
up these pending characters in the RX FIFO but disabling the RX
interrupt has potential to leave those characters in the RX FIFO. Does
it matter ?

Thanks

Dirk



\
 
 \ /
  Last update: 2014-05-30 08:21    [W:0.091 / U:0.144 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site