lkml.org 
[lkml]   [2014]   [May]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v4 2/3] mfd: intel_soc_pmic: Crystal Cove support


On 5/29/2014 7:49 PM, Lee Jones wrote:
> On Thu, 29 May 2014, Zhu, Lejun wrote:
>
>> This patch provides chip-specific support for Crystal Cove. Crystal
>> Cove is the PMIC in Baytrail-T platform.
(...)
>> +enum crystal_cove_irq {
>> + PWRSRC_IRQ = 0,
>> + THRM_IRQ,
>> + BCU_IRQ,
>> + ADC_IRQ,
>> + CHGR_IRQ,
>> + GPIO_IRQ,
>> + VHDMIOCP_IRQ
>> +};
>
> I can't help thinking that these should be nice clear #defines
>
> #define CRYSTAL_COVE_IRQ_PWSRC 0
> ...
> #define CRYSTAL_COVE_IRQ_VHDMIOCP 6
>

Sure. I'll fix it.

Best Regards
Lejun



\
 
 \ /
  Last update: 2014-05-30 07:41    [W:0.083 / U:0.684 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site