Messages in this thread | | | Date | Fri, 30 May 2014 13:01:11 +0800 | From | "Zhu, Lejun" <> | Subject | Re: [PATCH v4 2/3] mfd: intel_soc_pmic: Crystal Cove support |
| |
On 5/29/2014 7:49 PM, Lee Jones wrote: > On Thu, 29 May 2014, Zhu, Lejun wrote: > >> This patch provides chip-specific support for Crystal Cove. Crystal >> Cove is the PMIC in Baytrail-T platform. (...) >> +enum crystal_cove_irq { >> + PWRSRC_IRQ = 0, >> + THRM_IRQ, >> + BCU_IRQ, >> + ADC_IRQ, >> + CHGR_IRQ, >> + GPIO_IRQ, >> + VHDMIOCP_IRQ >> +}; > > I can't help thinking that these should be nice clear #defines > > #define CRYSTAL_COVE_IRQ_PWSRC 0 > ... > #define CRYSTAL_COVE_IRQ_VHDMIOCP 6 >
Sure. I'll fix it.
Best Regards Lejun
| |