Messages in this thread | | | Date | Sat, 3 May 2014 19:58:38 -0400 | From | Greg Kroah-Hartman <> | Subject | Re: [PATCH] staging/comedi: fix sparse warning: shift too big |
| |
On Fri, May 02, 2014 at 06:57:04PM +0400, Brilliantov Kirill Vladimirovich wrote: > Signed-off-by: Brilliantov Kirill Vladimirovich <brilliantov@inbox.ru> > --- > drivers/staging/comedi/drivers/ni_stc.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/comedi/drivers/ni_stc.h b/drivers/staging/comedi/drivers/ni_stc.h > index f0630b78..197b568 100644 > --- a/drivers/staging/comedi/drivers/ni_stc.h > +++ b/drivers/staging/comedi/drivers/ni_stc.h > @@ -717,7 +717,7 @@ enum AI_AO_Select_Bits { > static inline unsigned ni_stc_dma_channel_select_bitfield(unsigned channel) > { > if (channel < 4) > - return 1 << channel; > + return 1 << (channel & 0x3);
That change does nothing, so it's not worth applying, don't you agree?
thanks,
greg k-h
| |