Messages in this thread | | | Date | Thu, 29 May 2014 14:03:37 -0700 | From | Andrew Morton <> | Subject | Re: [PATCH] fs: ocfs2: move_extents.c: Fix to remove null pointer checks that could never happen |
| |
On Tue, 27 May 2014 22:23:51 +0200 Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se> wrote:
> Removal of null pointer checks that could never happen
How do you know it never happens?
> --- a/fs/ocfs2/move_extents.c > +++ b/fs/ocfs2/move_extents.c > @@ -904,9 +904,6 @@ static int ocfs2_move_extents(struct ocfs2_move_extents_context *context) > struct buffer_head *di_bh = NULL; > struct ocfs2_super *osb = OCFS2_SB(inode->i_sb); > > - if (!inode) > - return -ENOENT; > -
If it's due to assuming that the previous statement would have oopsed then that is mistaken. Is is sometimes the case that gcc will move the evaluation of inode->i_sb to after the test, so this function can be passed NULL and it will not oops.
| |