Messages in this thread | | | Date | Thu, 29 May 2014 21:55:43 +0200 | From | Fabian Frederick <> | Subject | Re: [PATCH V2 3/3] init/calibrate.c: no prefix in logging |
| |
On Thu, 29 May 2014 10:43:21 -0400 Paul Gortmaker <paul.gortmaker@windriver.com> wrote:
> [[PATCH V2 3/3] init/calibrate.c: no prefix in logging] On 29/05/2014 (Thu 10:14) Fabian Frederick wrote: > > > define pr_fmt without prefix to avoid any default prefix update > > Again, it isn't clear to me what you are trying to achieve here. > The printk.h header already has the define which you add here. > > A general rule for commits is to cover off three points. > > 1) Describe what the user visible symptom is, i.e. "printk from > calibrate.c are appearing with verbose prefix blah blah..." > > 2) Describe the underlying reason for the bug/issue, i.e. "This happens > because macro blah comes from foo.h but only when bar is defined." > > 3) Describe how your fix works and why it is the right/best fix for the > issue, i.e. "Here we introduce blah blah which will ensure ...." > > Also, to make life easier for maintainers, you probably want to add a > 0/N lead-in (see --cover-letter) which describes what you are trying to > achieve with the whole series, and when you create a v2 of the series, > you need to list in there for the maintainer how v2 differs from v1. > > Finally try not to send a v2 within hours of sending a v1 -- give a > chance for the v1 to get looked at 1st; typically at least one day. > > Thanks, > Paul.
Thanks for your help, I'll send more details.
Regards, Fabian
> -- > > > > > Cc: Paul Gortmaker <paul.gortmaker@windriver.com> > > Cc: Andrew Morton <akpm@linux-foundation.org> > > Signed-off-by: Fabian Frederick <fabf@skynet.be> > > --- > > init/calibrate.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/init/calibrate.c b/init/calibrate.c > > index fb9be44..169e98d 100644 > > --- a/init/calibrate.c > > +++ b/init/calibrate.c > > @@ -4,6 +4,8 @@ > > * Copyright (C) 1991, 1992 Linus Torvalds > > */ > > > > +#define pr_fmt(fmt) fmt > > + > > #include <linux/jiffies.h> > > #include <linux/delay.h> > > #include <linux/init.h> > > -- > > 1.9.1 > >
| |