Messages in this thread | | | Date | Thu, 29 May 2014 13:19:05 -0600 | From | Stephen Warren <> | Subject | Re: [PATCH v3] pinctrl: to avoid duplicated calling enable_pinmux_setting for a pin |
| |
On 05/25/2014 08:43 PM, fwu@marvell.com wrote: > From: Fan Wu <fwu@marvell.com> > > What the patch did: > 1.To call pinmux_disable_setting ahead of pinmux_enable_setting in each time of > calling pinctrl_select_state > 2.Remove the HW disable operation in in pinmux_disable_setting function. ...
This commit description is way too long for such a simple change. A much shorter summary would be better.
> Signed-off-by: Fan Wu <fwu@marvell.com> > Signed-off-by: Stephen Warren <swarren@nvidia.com>
I'm pretty sure I never signed off on this patch. How come my s-o-b line is there?
This patch still doesn't remove ops->disable from the struct pinmux_ops, nor any of its implementations. Shouldn't it?
| |