Messages in this thread | | | Date | Thu, 29 May 2014 17:54:37 +0100 | From | Lee Jones <> | Subject | Re: [PATCH 1/3] mfd: devicetree: bindings: Add Qualcomm RPM DT binding |
| |
> Add binding for the Qualcomm Resource Power Manager (RPM) found in 8660, 8960 > and 8064 based devices. The binding currently describes the rpm itself and the > regulator subnodes. > > Signed-off-by: Bjorn Andersson <bjorn.andersson@sonymobile.com> > --- > Documentation/devicetree/bindings/mfd/qcom,rpm.txt | 284 +++++++++++++++++++++ > include/dt-bindings/mfd/qcom_rpm.h | 142 +++++++++++ > 2 files changed, 426 insertions(+) > create mode 100644 Documentation/devicetree/bindings/mfd/qcom,rpm.txt > create mode 100644 include/dt-bindings/mfd/qcom_rpm.h
[...]
> diff --git a/include/dt-bindings/mfd/qcom_rpm.h b/include/dt-bindings/mfd/qcom_rpm.h > new file mode 100644 > index 0000000..277e789 > --- /dev/null > +++ b/include/dt-bindings/mfd/qcom_rpm.h > @@ -0,0 +1,142 @@ > +/* > + * This header provides constants for the Qualcomm RPM bindings. > + */
Proper header please.
> +#ifndef _DT_BINDINGS_MFD_QCOM_RPM_H > +#define _DT_BINDINGS_MFD_QCOM_RPM_H > + > +#define QCOM_RPM_APPS_FABRIC_ARB 1 > +#define QCOM_RPM_APPS_FABRIC_CLK 2 > +#define QCOM_RPM_APPS_FABRIC_HALT 3
[...]
> +#define QCOM_RPM_SYS_FABRIC_MODE 131 > +#define QCOM_RPM_USB_OTG_SWITCH 132 > +#define QCOM_RPM_VDDMIN_GPIO 133
Are you sure you don't want these in 0xXY format?
-- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |